[JTC] Add additional parameter to enable configuration of interfaces for following controllers in a chain. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
livanov93,
mcbed,
mhubii,
TomoyaFujita2016 and
UsamaHamayun1
|
This pull request is in conflict. Could you fix it @destogl? |
|
This pull request is in conflict. Could you fix it @destogl? |
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 35.78% 29.98% -5.80%
==========================================
Files 189 7 -182
Lines 17570 737 -16833
Branches 11592 422 -11170
==========================================
- Hits 6287 221 -6066
+ Misses 994 161 -833
+ Partials 10289 355 -9934
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pac48
reviewed
Aug 10, 2022
destogl
requested review from
pac48
and removed request for
TomoyaFujita2016 and
UsamaHamayun1
pac48
approved these changes
Aug 11, 2022
…for following controllers in a chain.
bmagyar
approved these changes
Aug 20, 2022
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
…for following controllers in a chain. (ros-controls#380) * [JTC] Add additional parameter to enable configuration of interfaces for following controllers in a chain. * Use command_joint_states correctly in parameters depending on joint states. * Fixup tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces example PR #318.
Changes:
gtesttogmock